How to fix: subprocess.Popen / os.popen with user input
subprocess.Popen(builtString, shell=True) and os.popen(builtString) both run their input through a shell. Even partial user influence over arguments enables command injection via metacharacters.
Why it matters
Shell injection through Popen/popen gives the attacker a shell on the host.
The `code-cmdi-popen` check verifies that the server does not expose the `cmdi-popen` weakness in the code category. The detection runs against the response headers, body, or auxiliary probes (DNS, TLS, async fetch) as appropriate.
How to fix it
- 1Always pass shell=False and an args list to Popen.
- 2Run untrusted input through shlex.quote before any shell-escape necessity.
- 3Set close_fds=True and use minimal env to reduce side effects.
Code examples
Use subprocess.run list form instead of popen string
# BAD: string command passed to popen is shell-injectable
import subprocess
subprocess.Popen(f"ls {user_dir}", shell=True)
# GOOD: list form with explicit args
subprocess.Popen(["ls", "-la", validated_dir], shell=False)References
Detected automatically by VulnRadar. The check id is code-cmdi-popen, stable across every scan so you can filter or diff on it.
More code checks
- CriticalForm Submits Data Over Insecure HTTP
- MediumPotential Prototype Pollution Sinks Detected
- HighPotential Command Injection Vectors
- HighJWT Decoded Without Signature Verification
- HighPotential Path Traversal Vulnerability
- HighInsecure Authentication Mechanisms Detected
- HighPotential Insecure Deserialization
- Mediumeval() Usage in Inline Scripts
Questions
- How severe is subprocess.Popen / os.popen with user input?
- VulnRadar rates this high severity in the code category. The severity is fixed per check, not scored per site, so the same finding is the same severity on every scan.
- Does VulnRadar check for this automatically?
- Yes. It runs as part of every scan under the check id code-cmdi-popen, which stays the same between runs so you can filter, diff, or gate CI on it.
- Which standards does subprocess.Popen / os.popen with user input map to?
- It maps to CWE-78. In the OWASP Top 10 it falls under A03:2021.
Missing a check?
The detection set is open. If you know a misconfiguration this does not catch, propose it: the issue template asks for the threat model, how to detect it, the false-positive risk, and a test fixture, which is the same thing a maintainer would have to work out anyway.