Skip to main content
CriticalCodeOWASP A03:2021CWE-78

How to fix: String-built /bin/sh invocation

Patterns like os.system("/bin/sh -c '" + userInput + "'") or exec("sh -c " + userInput) build a shell command via concatenation or interpolation, embedding attacker input into a parsed shell string.

Why it matters

Concatenated shell strings let attackers break out of quotes and execute arbitrary commands.

The `code-cmdi-bin-sh-concat` check verifies that the server does not expose the `cmdi-bin-sh-concat` weakness in the code category. The detection runs against the response headers, body, or auxiliary probes (DNS, TLS, async fetch) as appropriate.

How to fix it

  1. 1Eliminate the shell entirely: use execve, subprocess.run(args), or Node's spawn with an arg array.
  2. 2If a shell is mandatory, use shlex.quote or equivalent escaping on every variable.
  3. 3Validate the final command against an allowlist of permitted executables and flags.

Code examples

Never concatenate user input into shell strings

TypeScript
// BAD: string concatenation into /bin/sh
exec(`/bin/sh -c "convert ${filename} output.jpg"`);

// GOOD: execFile with separate args
execFile("/usr/bin/convert", [filename, "output.jpg"], {
  shell: false,
  timeout: 5_000,
});

References

Detected automatically by VulnRadar. The check id is code-cmdi-bin-sh-concat, stable across every scan so you can filter or diff on it.

See every code check

Questions

How severe is String-built /bin/sh invocation?
VulnRadar rates this critical severity in the code category. The severity is fixed per check, not scored per site, so the same finding is the same severity on every scan.
Does VulnRadar check for this automatically?
Yes. It runs as part of every scan under the check id code-cmdi-bin-sh-concat, which stays the same between runs so you can filter, diff, or gate CI on it.
Which standards does String-built /bin/sh invocation map to?
It maps to CWE-78. In the OWASP Top 10 it falls under A03:2021.

Missing a check?

The detection set is open. If you know a misconfiguration this does not catch, propose it: the issue template asks for the threat model, how to detect it, the false-positive risk, and a test fixture, which is the same thing a maintainer would have to work out anyway.

Propose a checkHow a check is built

Scan your own site for string-built /bin/sh invocation

VulnRadar runs this check and hundreds more against a URL in seconds. No agent to install, just paste a URL.

Or scan this site as a demoRead the docs

How to fix: String-built /bin/sh invocation | VulnRadar